Infinitime Simple Weather Service #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the conversion of the city name was generating invalid characters (16bits? utf8?). Now, it generated plain 8-bit ASCII. - a typo around the temperature conversion (237.15 -> 273.15)
…ication from InfiniTime : new service UUID, remove the location string from the forecast and update the weather condition icons.
…nstead of uint8_t to store the temperature).
|
We merged the new Simple Weather Service in InfiniTime. I did most of my tests using this PR in Amazfish, so I guess it's pretty safe to merge it ;-) |
jmlich
changed the title
|
There is a few things to consider
|
|
I should probably rename the service to pinetimesimpleweatherservice to highlight that this is pinetime specific. |
|
Good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is was created in cooperation with @JF002 in scope of #308. (Closes #308)
Documentation of the service and reasons are described in InfiniTime pull request.
InfiniTimeOrg/InfiniTime#1924
I have update the osm weather in order to provide icon and temperature in qreal, because it converted from kelvins which adds unwanted error to the value (for example 274.9 kelvins ~ 274 - 273 = 1 deg, but it should be 274.9 - 273.15 = 1.75 ~ 2 deg). The weather icon is displayed in cityselection dialog.